Totally agree. The issue is definitely *NOT* the responsibility of libtiff. Just trying to document the issue for folks who may have hit it. The most recent file in https://sourceforge.net/projects/freeimage/files/ is 2018 and the project doesn't look to be active (e.g. it has a cvs repo that is now read only on sourceforge and I didn't see an official spot on github)
On Fri, May 20, 2022 at 11:04 AM Even Rouault <[email protected]> wrote: > Kurt, > > The _TIFFDataSize() symbol that Freeimage used was in the private & > non-installed tiffiop.h header, so they weren't supposed to use it. I also > suspect that their code might not have linked on Windows. > > Even > Le 20/05/2022 à 19:56, Kurt Schwehr a écrit : > > Thanks Even! > > I can't comment on the point release RC directly, but... > > I've been using libtiff from head (with my own bazel based build system + > my own mods to the generated headers) and have not heard any reports of > trouble across the huge number of targets that use it. > > The only issue I ran into was with https://freeimage.sourceforge.io/. > Here is the patch I used. I only have one version of libtiff, so I didn't > have to worry about making this an ifdef. > > diff -ru a/files/Source/Metadata/XTIFF.cpp > b/files/Source/Metadata/XTIFF.cpp > --- a/files/Source/Metadata/XTIFF.cpp 2022-05-18 06:56:41.578314458 -0700 > +++ b/files/Source/Metadata/XTIFF.cpp 2022-05-18 12:51:56.674454816 -0700 > @@ -749,7 +749,7 @@ > continue; > } > // type of storage may differ (e.g. rationnal array vs float array type) > - if((unsigned)_TIFFDataSize(tif_tag_type) != > FreeImage_TagDataWidth(tag_type)) { > + if((unsigned)TIFFFieldSetGetSize(fld) != > FreeImage_TagDataWidth(tag_type)) { > // skip tag or _TIFFmemcpy will fail > continue; > } > > I've sent this to free image, so they can make a proper patch if they want: > > > https://sourceforge.net/p/freeimage/discussion/36109/thread/2018fdc6e7/#393d > > -kurt > > On Fri, May 20, 2022 at 9:38 AM Even Rouault <[email protected]> > wrote: > >> Hi, >> >> I've prepare a release candidate for libtiff v4.4.0: >> >> - https://download.osgeo.org/libtiff/tiff-4.4.0rc1.tar.gz >> >> - https://download.osgeo.org/libtiff/tiff-4.4.0rc1.tar.gz.sig >> >> - https://download.osgeo.org/libtiff/tiff-4.4.0rc1.tar.xz >> >> - https://download.osgeo.org/libtiff/tiff-4.4.0rc1.tar.xz.sig >> >> - https://download.osgeo.org/libtiff/tiff-4.4.0rc1.zip >> >> - https://download.osgeo.org/libtiff/tiff-4.4.0rc1.zip.sig >> >> Release notes at https://libtiff.gitlab.io/libtiff/v4.4.0.html >> >> I'll promote it to final next week if no serious blocking issues are >> reported. >> >> Best regards, >> >> -- >> http://www.spatialys.com >> My software is free, but my time generally not. >> >> _______________________________________________ >> Tiff mailing list >> [email protected] >> https://lists.osgeo.org/mailman/listinfo/tiff >> > -- http://www.spatialys.com > My software is free, but my time generally not. > >
_______________________________________________ Tiff mailing list [email protected] https://lists.osgeo.org/mailman/listinfo/tiff
