Hi, Probably nitpick, but isn't CMake convention to call the last component "patch" instead of "micro"? I think the latter's Autotools only.
Best, amyspark On 10/12/2022 10:29, Even Rouault wrote: > Hi, > > annoying that FindTIFF.cmake is so formatting sensitive, but I've > reverted the reformatting of that file in > https://gitlab.com/libtiff/libtiff/-/merge_requests/434 > > I've also added long overdue TIFFLIB_MAJOR_VERSION, > TIFFLIB_MINOR_VERSION, TIFFLIB_MICRO_VERSION defines > > Even > > Le 10/12/2022 à 11:40, Kai Pastor, DG0YT a écrit : >> Thanks for your work! >> >> There is an issue with tiff_vers.h: >> The new linebreak style of the TIFF_VERSION_STR definition breaks >> version detection in CMake's FindTIFF.cmake, >> leaving TIFF_VERSION unset (in CMake). Some packages rely on this >> variable. E.g. openimageio in vcpkg: >> >> -- Found TIFF >> CMake Error at src/cmake/checked_find_package.cmake:154 (if): >> if given arguments: >> >> "VERSION_LESS" "4.0" >> >> Unknown arguments specified >> Call Stack (most recent call first): >> src/cmake/externalpackages.cmake:90 (checked_find_package) >> CMakeLists.txt:141 (include) >> >> >> which probably comes from some >> >> if(${TIFF_VERSION} VERSION_LESS "4.0") >> >> I would suggest to restore a formatting which doesn't break existing >> CMake code. >> >> Regards, Kai >> >> Am 09.12.22 um 16:48 schrieb Even Rouault: >>> Hi, >>> >>> I've prepared a release candidate for libtiff v4.5.0: >>> >>> - https://download.osgeo.org/libtiff/tiff-4.5.0rc1.tar.gz >>> - https://download.osgeo.org/libtiff/tiff-4.5.0rc1.tar.gz.sig >>> - https://download.osgeo.org/libtiff/tiff-4.5.0rc1.tar.xz >>> - https://download.osgeo.org/libtiff/tiff-4.5.0rc1.tar.xz.sig >>> - https://download.osgeo.org/libtiff/tiff-4.5.0rc1.zip >>> - https://download.osgeo.org/libtiff/tiff-4.5.0rc1.zip.sig >>> >>> Release notes at https://libtiff.gitlab.io/libtiff/releases/v4.5.0.html >>> >>> I'll promote it to final next week if no serious blocking issues are >>> reported. >>> >>> Thanks to all contributors. >>> >>> Best regards, >>> >> >> _______________________________________________ >> gdal-dev mailing list >> [email protected] >> https://lists.osgeo.org/mailman/listinfo/gdal-dev > -- amyspark 🌸 https://www.amyspark.me _______________________________________________ Tiff mailing list [email protected] https://lists.osgeo.org/mailman/listinfo/tiff
