Revision: 4325
http://tigervnc.svn.sourceforge.net/tigervnc/?rev=4325&view=rev
Author: ossman_
Date: 2011-03-08 12:18:13 +0000 (Tue, 08 Mar 2011)
Log Message:
-----------
Complete misunderstanding on my part. CMAKE_CL_64 indicates a _Microsoft_
compiler and is not a generic test for 64-bit. Start looking at the size
of void* instead.
Modified Paths:
--------------
trunk/CMakeLists.txt
trunk/win/installer/CMakeLists.txt
Modified: trunk/CMakeLists.txt
===================================================================
--- trunk/CMakeLists.txt 2011-03-07 12:52:37 UTC (rev 4324)
+++ trunk/CMakeLists.txt 2011-03-08 12:18:13 UTC (rev 4325)
@@ -51,14 +51,6 @@
endif()
endif()
-# CMake 64-bit detection leaves a bit to be desired and is sometimes
-# not properly set. Specifically we see this with mingw64. Try to
-# detect this scenario and fix things.
-if(NOT CMAKE_CL_64 AND CMAKE_SIZEOF_VOID_P MATCHES 8)
- message(STATUS "WARNING: CMake misdetected 64-bit build. Fixing...")
- set(CMAKE_CL_64 1)
-endif()
-
if(MSVC)
# Use the static C library for all build types
foreach(var CMAKE_C_FLAGS CMAKE_C_FLAGS_DEBUG CMAKE_C_FLAGS_RELEASE
@@ -76,7 +68,7 @@
add_definitions(-wd4244 -wd4267 -wd4800 -wd4996)
endif()
-if(CMAKE_CL_64)
+if(CMAKE_SIZEOF_VOID_P MATCHES 8)
message(STATUS "64-bit build")
else()
message(STATUS "32-bit build")
@@ -139,7 +131,7 @@
include_directories(${CMAKE_BINARY_DIR})
# Minimum version is Windows 2000 (5.0)
-if(NOT CMAKE_CL_64)
+if(NOT CMAKE_SIZEOF_VOID_P MATCHES 8)
add_definitions(-D_WIN32_IE=0x0500 -D_WIN32_WINNT=0x0500)
else()
# Win64 doesn't like us requesting a Windows version that didn't have
Modified: trunk/win/installer/CMakeLists.txt
===================================================================
--- trunk/win/installer/CMakeLists.txt 2011-03-07 12:52:37 UTC (rev 4324)
+++ trunk/win/installer/CMakeLists.txt 2011-03-08 12:18:13 UTC (rev 4325)
@@ -1,4 +1,5 @@
-if(CMAKE_CL_64)
+# Detect a 64-bit build and give that installer a different name
+if(CMAKE_SIZEOF_VOID_P MATCHES 8)
set(INST_NAME ${CMAKE_PROJECT_NAME}64-${VERSION})
set(INST_DEFS -DWIN64)
else()
This was sent by the SourceForge.net collaborative development platform, the
world's largest Open Source development site.
------------------------------------------------------------------------------
What You Don't Know About Data Connectivity CAN Hurt You
This paper provides an overview of data connectivity, details
its effect on application quality, and explores various alternative
solutions. http://p.sf.net/sfu/progress-d2d
_______________________________________________
Tigervnc-commits mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/tigervnc-commits
