Hi,

on 32bit systems vncpasswd dies on invalid free() when you specify
password longer than 12 characters. After inspection problem is
missing constructor.

Reference:
https://bugzilla.redhat.com/show_bug.cgi?id=499401

Proposed patch (trunk + 1_0) is attached.

Regards, Adam

-- 
Adam Tkac, Red Hat, Inc.
Index: common/rfb/Password.cxx
===================================================================
--- common/rfb/Password.cxx     (revision 3809)
+++ common/rfb/Password.cxx     (working copy)
@@ -38,6 +38,9 @@
 PlainPasswd::PlainPasswd(char* pwd) : CharArray(pwd) {
 }
 
+PlainPasswd::PlainPasswd(int len) : CharArray(len) {
+}
+
 PlainPasswd::PlainPasswd(const ObfuscatedPasswd& obfPwd) : CharArray(9) {
   if (obfPwd.length < 8)
     throw rdr::Exception("bad obfuscated password length");
Index: common/rfb/Password.h
===================================================================
--- common/rfb/Password.h       (revision 3809)
+++ common/rfb/Password.h       (working copy)
@@ -28,6 +28,7 @@
   public:
     PlainPasswd();
     PlainPasswd(char* pwd);
+    PlainPasswd(int len);
     PlainPasswd(const ObfuscatedPasswd& obfPwd);
     ~PlainPasswd();
     void replaceBuf(char* b);
------------------------------------------------------------------------------
The NEW KODAK i700 Series Scanners deliver under ANY circumstances! Your
production scanning environment may not be a perfect world - but thanks to
Kodak, there's a perfect scanner to get the job done! With the NEW KODAK i700
Series Scanner you'll get full speed at 300 dpi even with all image 
processing features enabled. http://p.sf.net/sfu/kodak-com
_______________________________________________
Tigervnc-devel mailing list
Tigervnc-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/tigervnc-devel

Reply via email to