On Thu, May 28, 2009 at 09:36:59PM +0200, Peter Åstrand wrote: > On Thu, 28 May 2009, Adam Tkac wrote: > >>> one man reported problem that vncviewer doesn't show Russian letters >>> (https://bugzilla.redhat.com/show_bug.cgi?id=501832). >>> >> Ok, based on discussion in this thread I created proposed patch. >> Gettext is used only if user uses iso-8859-1 or iso-8859-2 encoding. > > I'm not convinced. What would be the advantage of this big patch, > compared to just removing "ru" from the LINGUAS file? Why only iso-8859-1 > and iso-8859-2, and not, say, iso-8859-15? I also don't understand we > would need a special underscore-function, wouldn't it be sufficient with > just skipping the activation of gettext, if the locale is "wrong"?
Ok, you have persuaded me. Improved patch is attached. Regards, Adam -- Adam Tkac, Red Hat, Inc.
Index: unix/po/LINGUAS =================================================================== --- unix/po/LINGUAS (revision 3820) +++ unix/po/LINGUAS (working copy) @@ -1 +1 @@ -sv de sk ru +sv de sk
------------------------------------------------------------------------------ Register Now for Creativity and Technology (CaT), June 3rd, NYC. CaT is a gathering of tech-side developers & brand creativity professionals. Meet the minds behind Google Creative Lab, Visual Complexity, Processing, & iPhoneDevCamp as they present alongside digital heavyweights like Barbarian Group, R/GA, & Big Spaceship. http://p.sf.net/sfu/creativitycat-com
_______________________________________________ Tigervnc-devel mailing list Tigervnc-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/tigervnc-devel
