On Mon, Jun 01, 2009 at 09:11:19AM +0200, Pierre Ossman wrote:
> On Fri, 29 May 2009 16:17:47 +0200
> Pierre Ossman <oss...@cendio.se> wrote:
>
> > The scaling buffer did not take into account that DIBSectionBuffer
> > might modify the given pixel format. Read it back so that the variables
> > are consistent.
> >
> > Should be applied to the 1_0 branch.
> >
>
> And the actual patch:
>
> Index: rfb_win32/ScaledDIBSectionBuffer.cxx
> ===================================================================
> --- rfb_win32/ScaledDIBSectionBuffer.cxx (revision 3815)
> +++ rfb_win32/ScaledDIBSectionBuffer.cxx (working copy)
> @@ -66,6 +66,7 @@
> }
> } else {
> DIBSectionBuffer::setPF(pf);
> + pf = format;
> }
> }
Patch is correct.
PS: design of the ScaledDIBSectionBuffer and DIBSectionBuffer classes is
the best example how not to do object oriented programming...
Regards, Adam
--
Adam Tkac, Red Hat, Inc.
------------------------------------------------------------------------------
Register Now for Creativity and Technology (CaT), June 3rd, NYC. CaT
is a gathering of tech-side developers & brand creativity professionals. Meet
the minds behind Google Creative Lab, Visual Complexity, Processing, &
iPhoneDevCamp as they present alongside digital heavyweights like Barbarian
Group, R/GA, & Big Spaceship. http://p.sf.net/sfu/creativitycat-com
_______________________________________________
Tigervnc-devel mailing list
Tigervnc-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/tigervnc-devel
