On Tue, 2 Jun 2009 13:09:08 +0200 Adam Tkac <at...@redhat.com> wrote:
> > Hm, patch doesn't look fine for me. > > First, we should use same DPI in vfbScreenInit and vncRandRSetConfig > functions. It does since it first fetches the existing DPI. Duplicating the code from vfbScreenInit just increases the risk of getting things different as you have a SPOT violation and there might be other things in X modifying the DPI. > Also I don't understand your magical constants - 254 should > be 25.4, shouldn't it? It's basically fixed point math, which gives you decent resolution without having to resort to floating point. It's the same method used in mi/, which means we should have the same rounding errors as the rest of Xorg. > I think we should try to be consistent with the bare Xorg. Otherwise > libvnc.so module could have problems. This is in the Xvnc specific parts so libvnc.so is unaffected. Rgds -- Pierre Ossman OpenSource-based Thin Client Technology System Developer Telephone: +46-13-21 46 00 Cendio AB Web: http://www.cendio.com
signature.asc
Description: PGP signature
------------------------------------------------------------------------------ OpenSolaris 2009.06 is a cutting edge operating system for enterprises looking to deploy the next generation of Solaris that includes the latest innovations from Sun and the OpenSource community. Download a copy and enjoy capabilities such as Networking, Storage and Virtualization. Go to: http://p.sf.net/sfu/opensolaris-get
_______________________________________________ Tigervnc-devel mailing list Tigervnc-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/tigervnc-devel
