On Fri, 12 Jun 2009 14:31:51 +0200
Adam Tkac <at...@redhat.com> wrote:

> Hi all,
> 
> vncviewer doesn't receive clipboard selection from server.
> 
> CMsgReader::readServerCutText function calls handler->serverCutText()
> but this call is not correctly propagated to the corresponding CConn method.
> After inspection main problem is wrong prototype of the
> CConn::serverCutText function. It has to be same as prototype of the
> CMsgHandler::serverCutText function.
> 
> I also modified CMsgHandler class to contain pure virtual methods
> instead of methods with empty body. This modification will eliminate
> annoying problems like bad CConn::serverCutText prototype in future.
> 
> Patch should be commited to both 1.0 and trunk.
> 

Looks ok. But I think you should do the fix and the pure virtual stuff
in two separate commits.

-- 
Pierre Ossman            OpenSource-based Thin Client Technology
System Developer         Telephone: +46-13-21 46 00
Cendio AB                Web: http://www.cendio.com

Attachment: signature.asc
Description: PGP signature

------------------------------------------------------------------------------
Crystal Reports - New Free Runtime and 30 Day Trial
Check out the new simplified licensing option that enables unlimited
royalty-free distribution of the report engine for externally facing 
server and web deployment.
http://p.sf.net/sfu/businessobjects
_______________________________________________
Tigervnc-devel mailing list
Tigervnc-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/tigervnc-devel

Reply via email to