On Wed, Sep 30, 2009 at 04:25:57PM +0200, Adam Tkac wrote:
> On Wed, Sep 09, 2009 at 09:58:39AM +0200, Pierre Ossman wrote:
> > On Thu, 3 Sep 2009 17:03:42 +0200
> > Adam Tkac <at...@redhat.com> wrote:
> >
> > > Hi all,
> > >
> > > vncviewer completely ignores -LowColorLevel switch. Proposed patch is
> > > attached, should be fixed in both 1.0 and trunk.
> > >
> > > Reference: https://bugzilla.redhat.com/show_bug.cgi?id=510185
> > >
> > > Regards, Adam
> > >
> >
> > NAK. This is not a bug but a matter of unintuitive user interface. As
> > such, I don't think it is something that should be changed in a stable
> > branch as there most likely are people out there relying on the current
> > interface.
>
> Ok, then let's improve documentation, improvement is called as
> LowColorLevel.patch.
>
> Second patch (LowColorLevel2.patch) disables full color mode when both
> AutoSelect=0 and LowColorLevel= options are specified. There is no
> reason to have FullColor=1 and LowColor set when auto selection is
> disabled.
>
> Both patches will be commited to 1.0 and trunk.
Bleh, I forgot to attach the patches...
--
Adam Tkac, Red Hat, Inc.
Index: unix/vncviewer/vncviewer.man
===================================================================
--- unix/vncviewer/vncviewer.man (revision 3902)
+++ unix/vncviewer/vncviewer.man (working copy)
@@ -156,7 +156,9 @@
.B \-LowColorLevel, \-LowColourLevel \fIlevel\fP
Selects the reduced color level to use on slow links. \fIlevel\fP can range
from 0 to 2, 0 meaning 8 colors, 1 meaning 64 colors (the default), 2 meaning
-256 colors.
+256 colors. Note that decision if reduced color level is used is made by
+vncviewer. If you would like to force vncviewer to use reduced color level
+use \fB-AutoSelect=0\fP parameter.
.TP
.B \-PreferredEncoding \fIencoding\fP
Index: unix/vncviewer/vncviewer.cxx
===================================================================
--- unix/vncviewer/vncviewer.cxx (revision 3902)
+++ unix/vncviewer/vncviewer.cxx (working copy)
@@ -337,6 +337,13 @@
&& !::fullColour.hasBeenSet()
&& !::fullColourAlias.hasBeenSet());
}
+ if (!::fullColour.hasBeenSet() && !::fullColourAlias.hasBeenSet()) {
+ // Default to FullColor=0 if AutoSelect=0 && LowColorLevel is set
+ if (!::autoSelect && (::lowColourLevel.hasBeenSet() ||
+ ::lowColourLevelAlias.hasBeenSet())) {
+ ::fullColour.setParam(false);
+ }
+ }
if (!::customCompressLevel.hasBeenSet()) {
// Default to CustomCompressLevel=1 if CompressLevel is used.
::customCompressLevel.setParam(::compressLevel.hasBeenSet());
------------------------------------------------------------------------------
Come build with us! The BlackBerry® Developer Conference in SF, CA
is the only developer event you need to attend this year. Jumpstart your
developing skills, take BlackBerry mobile applications to market and stay
ahead of the curve. Join us from November 9-12, 2009. Register now!
http://p.sf.net/sfu/devconf
_______________________________________________
Tigervnc-devel mailing list
Tigervnc-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/tigervnc-devel
