On Thu, 8 Oct 2009 13:51:58 +0200 Adam Tkac <at...@redhat.com> wrote:
> On Thu, Oct 08, 2009 at 06:30:10PM +0700, Antoine Martin wrote: > > -----BEGIN PGP SIGNED MESSAGE----- > > Hash: SHA512 > > > > > please check my comments directly in the patch. Note I can't > > > test winvnc bits because currently I don't have any VC++ > > > environment but changes there look fine for me. You don't have to > > > attach new patch, only let us know if changes suggested below works > > > for you > > ACK > > Everything compiled fine, briefly tested too. > > Thanks, commited as r3912 to both 1_0 branch and trunk. > I'd prefer if this was backed out. As I said, this just hides the obvious unicode handling errors without actually verifying that the rest of the code can handle it. We would need a huge audit to remove all references to the "normal" string handling functions for that*. * Something which I don't support. We should be using UTF-8 for unicode, not UTF-16. Rgds -- Pierre Ossman OpenSource-based Thin Client Technology System Developer Telephone: +46-13-21 46 00 Cendio AB Web: http://www.cendio.com
signature.asc
Description: PGP signature
------------------------------------------------------------------------------ Come build with us! The BlackBerry(R) Developer Conference in SF, CA is the only developer event you need to attend this year. Jumpstart your developing skills, take BlackBerry mobile applications to market and stay ahead of the curve. Join us from November 9 - 12, 2009. Register now! http://p.sf.net/sfu/devconference
_______________________________________________ Tigervnc-devel mailing list Tigervnc-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/tigervnc-devel
