> Modified: trunk/common/jpeg/simd/jsimd_i386.c
> ===================================================================
> --- trunk/common/jpeg/simd/jsimd_i386.c 2010-02-26 23:27:25 UTC (rev 3997)
> +++ trunk/common/jpeg/simd/jsimd_i386.c 2010-02-26 23:30:15 UTC (rev 3998)
> @@ -48,16 +48,16 @@
>    /* Force different settings through environment variables */
>    env = getenv("JSIMD_FORCEMMX");
>    if ((env != NULL) && (strcmp(env, "1") == 0))
> -    simd_support &= JSIMD_MMX;
> +    simd_support = JSIMD_MMX;
>    env = getenv("JSIMD_FORCE3DNOW");
>    if ((env != NULL) && (strcmp(env, "1") == 0))
> -    simd_support &= JSIMD_3DNOW;
> +    simd_support = JSIMD_3DNOW|JSIMD_MMX;
>    env = getenv("JSIMD_FORCESSE");
>    if ((env != NULL) && (strcmp(env, "1") == 0))
> -    simd_support &= JSIMD_SSE;
> +    simd_support = JSIMD_SSE|JSIMD_MMX;
>    env = getenv("JSIMD_FORCESSE2");
>    if ((env != NULL) && (strcmp(env, "1") == 0))
> -    simd_support &= JSIMD_SSE2;
> +    simd_support = JSIMD_SSE2;
>  }
>  
>  GLOBAL(int)

I'm not sure I like this. Although it does take the word "force" more
literally here, the previous code was safe from foot shooting. With
this you can enable e.g. SSE2 on a cpu that doesn't support it and end
up with SIGILL.

Rgds
-- 
Pierre Ossman            OpenSource-based Thin Client Technology
System Developer         Telephone: +46-13-21 46 00
Cendio AB                Web: http://www.cendio.com

Attachment: signature.asc
Description: PGP signature

------------------------------------------------------------------------------
Download Intel® Parallel Studio Eval
Try the new software tools for yourself. Speed compiling, find bugs
proactively, and fine-tune applications for parallel performance.
See why Intel Parallel Studio got high marks during beta.
http://p.sf.net/sfu/intel-sw-dev
_______________________________________________
Tigervnc-devel mailing list
Tigervnc-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/tigervnc-devel

Reply via email to