I don't know if the X server build in general is supposed to work on non-GCC compilers, but -Wl would certainly fail on anything but GCC, so I am not comfortable introducing that incompatibility unless the incompatibility already exists.
It would definitely fail on OS X, but I think there are probably 50 other things in the Xvnc build that would fail first. :) The more relevant question is whether it will fail on Solaris, and I think the answer is "yes" there as well. IMHO, the "right" thing to do would be to add a check for this linker option to configure.ac, then only include the flag in LDFLAGS if the linker option exists and GCC is being used. But, of course, that would require modifying the X server patches, which is a pain. On 4/27/10 8:43 AM, Adam Tkac wrote: > Hello, > > when Xorg loads libvnc.so module, undefined symbols are not resolved > immediately but they are resolved "on demand". This might look like a > benefit but I don't think so. > > I often hit problems that Xorg loads libvnc.so without any problem > and then X session crashes due undefined symbol, when less used code > path inside libvnc.so is executed and it contains symbol which is not > exported from Xorg binary. > > I propose to switch to immediately linkage which will avoid such problems > and undefined symbols will be catched during module loading. > > Proposed patch is attached but I'm not sure about compatibility. Do > you know if it can cause build failures on, for example, OS X? > > Comments are welcomed. > > Regards, Adam > > > > > ------------------------------------------------------------------------------ > > > > _______________________________________________ > Tigervnc-devel mailing list > Tigervnc-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/tigervnc-devel ------------------------------------------------------------------------------ _______________________________________________ Tigervnc-devel mailing list Tigervnc-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/tigervnc-devel
