On Wed, Apr 28, 2010 at 02:53:10PM -0500, DRC wrote: > There are a couple of problems with this, as I see it:
Hello all, I read the whole thread, read my opinions below. > 1) GNU TLS support is enabled by default, so if GNU TLS isn't installed > on the system (which is the case for non-Linux systems, generally), then > configure fails. Our build should not require GNU TLS, nor should it > require that the user explicitly specify --disable-gnutls. > > 2) The PKG_CHECK_MODULES macro isn't generally available on all systems. > Not just OS X, as it turns out. A Google search of several forums > seems to indicate that it isn't present on FreeBSD as well. > > 3) The PKG_CHECK_MODULES macro always generates a fatal condition if GNU > TLS isn't available. > > > I believe that the behavior should be as follows: > > -- A mechanism other than PKG_CHECK_MODULES should be used to detect the > presence of GNU TLS (AC_CHECK_LIB or AC_CHECK_HEADER, probably.) Yes, we can abandon PKG_CHECK_MODULES macro and use AC_CHECK_LIB instead. It might be bigger as Pierre said but it will be far more compatible. I think that AC_CHECK_LIB is sufficient, no AC_CHECK_HEADER is needed. > -- If GNU TLS is present, then it should be enabled by default. If it > is not present, then it should be disabled by default. Ok. It will be easily achievable with the AC_CHECK_LIB macro. Regards, Adam -- Adam Tkac, Red Hat, Inc. ------------------------------------------------------------------------------ _______________________________________________ Tigervnc-devel mailing list Tigervnc-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/tigervnc-devel
