On Thu, Sep 02, 2010 at 09:05:53AM +0200, Martin Koegler wrote:
> diff --git a/common/rfb/Security.cxx b/common/rfb/Security.cxx
> index 71e45de..708c10a 100644
> --- a/common/rfb/Security.cxx
> +++ b/common/rfb/Security.cxx
> @@ -31,6 +31,7 @@
> #include <rfb/CSecurityStack.h>
> #include <rfb/CSecurityVeNCrypt.h>
> #include <rfb/CSecurityVncAuth.h>
> +#include <rfb/CSecurityPlain.h>
> #include <rdr/Exception.h>
> #include <rfb/LogWriter.h>
> #include <rfb/Security.h>
> @@ -56,7 +57,7 @@ StringParameter Security::secTypesViewer
> ("SecurityTypes",
> "Specify which security scheme to use (None, VncAuth)",
> #ifdef HAVE_GNUTLS
> - "VeNCrypt,X509Vnc,TLSVnc,X509None,TLSNone,VncAuth,None",
> +
> "VeNCrypt,X509Plain,TLSPlain,X509Vnc,TLSVnc,X509None,TLSNone,Plain,VncAuth,None",
I would rather disable "Plain" type by default because it is real
security hazard. I've commited your patch without "Plain" in the
default list. User can manually select it.
Rest of the patch is OK, I've commited it as r4127. Thank you very
much.
Regards, Adam
--
Adam Tkac, Red Hat, Inc.
------------------------------------------------------------------------------
This SF.net Dev2Dev email is sponsored by:
Show off your parallel programming skills.
Enter the Intel(R) Threading Challenge 2010.
http://p.sf.net/sfu/intel-thread-sfd
_______________________________________________
Tigervnc-devel mailing list
Tigervnc-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/tigervnc-devel
