On Wed, 1 Dec 2010 13:11:37 +0100 Adam Tkac <at...@redhat.com> wrote:
> On Wed, Dec 01, 2010 at 10:46:36AM +0100, Peter Åstrand wrote: > > > > >We are casting pDrawable, but with the XDrawArc case, the drawable > > >is not a window but a pixmap. Pixmap structures doesn't have a > > >borderClip member. > > > > > >Why do we need to deal with pixmaps at all? In revision r2452, we started > > > > If we need to continue hooking pixmap operations, this patch should > > solve the problem: > > Patch looks fine for me, feel free to commit it. > I'm not feeling entirely comfortable with this thing. Looking at r2452, the commit message doesn't really explain what's going on. From what I gather, the PaintWindowBackground and PaintWindowBorder hooks are deprecated and hence that portion is a cleanup. The modifications to ValidateGC seem unrelated and should probably have been a separate commit. The commit message hints about some relationship though, but the description "PolyFillRect hook is used instead and it needs modified ValidateGC hook." doesn't really make sense as that hook isn't added by that commit. Was it broken beforehand? It also gives no mention to the fact that Pixmaps are grabbed and not just Windows and no justification as to why this is suddenly needed. Adam, you need to elaborate here on what's going on and why r2452 was needed in the first place. Rgds -- Pierre Ossman OpenSource-based Thin Client Technology System Developer Telephone: +46-13-21 46 00 Cendio AB Web: http://www.cendio.com A: Because it messes up the order in which people normally read text. Q: Why is top-posting such a bad thing?
signature.asc
Description: PGP signature
------------------------------------------------------------------------------ Increase Visibility of Your 3D Game App & Earn a Chance To Win $500! Tap into the largest installed PC base & get more eyes on your game by optimizing for Intel(R) Graphics Technology. Get started today with the Intel(R) Software Partner Program. Five $500 cash prizes are up for grabs. http://p.sf.net/sfu/intelisp-dev2dev
_______________________________________________ Tigervnc-devel mailing list Tigervnc-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/tigervnc-devel
