On Fri, 04 Mar 2011 09:39:36 -0600 DRC <dcomman...@users.sourceforge.net> wrote:
> I'm really quite distressed at all of these modifications, because I
> spent quite a bit of time making sure that the CMake build system for
> Windows worked well on MinGW + GMake, MinGW64 + GMake, Visual C++ 32-bit
> and 64-bit + NMake, Visual C++ 32-bit + Visual Studio IDE, and MinGW
> cross-compiled on Linux. This is what I said earlier when we were
> discussing whether to merge the Unix build into CMake-- the CMake system
> is somewhat fragile. It works exactly as I designed it, but every piece
> of code in there is in there for a reason.
Well, if it's fragile then those issues should be fully documented.
Otherwise there is no way to move forward with it without breaking
things. And a build system we cannot modify is a build system we cannot
use.
> It should not be necessary to specify a minimum platform of Windows XP.
> Please describe the exact build problem you are having which inspired
> this patch.
/usr/x86_64-w64-mingw32/sys-root/mingw/include/shlobj.h:14:2: error: #error
_WIN32_IE setting conflicts
In file included from
/usr/x86_64-w64-mingw32/sys-root/mingw/include/shlobj.h:88,
from /home/ossman/devel/tigervnc/clean/common/os/os.cxx:36:
/usr/x86_64-w64-mingw32/sys-root/mingw/include/shlguid.h:13:2: error: #error
_WIN32_IE setting conflicts
make[2]: *** [common/os/CMakeFiles/os.dir/os.cxx.obj] Error 1
make[1]: *** [common/os/CMakeFiles/os.dir/all] Error 2
make: *** [all] Error 2
And looking in shlobj.h:
#ifndef _WINRESRC_
#ifndef _WIN32_IE
#define _WIN32_IE 0x0501
#else
#if (_WIN32_IE < 0x0501)
#error _WIN32_IE setting conflicts
#endif
#endif
#endif
Rgds
--
Pierre Ossman OpenSource-based Thin Client Technology
System Developer Telephone: +46-13-21 46 00
Cendio AB Web: http://www.cendio.com
A: Because it messes up the order in which people normally read text.
Q: Why is top-posting such a bad thing?
signature.asc
Description: PGP signature
------------------------------------------------------------------------------ What You Don't Know About Data Connectivity CAN Hurt You This paper provides an overview of data connectivity, details its effect on application quality, and explores various alternative solutions. http://p.sf.net/sfu/progress-d2d
_______________________________________________ Tigervnc-devel mailing list Tigervnc-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/tigervnc-devel
