I checked in the fix, but I'm still not able to figure out how to get
the copy filter to engage. How are you doing that? None of the
TightVNC family of VNC servers even generates that subencoding on the
server end. It's not in TightVNC, even as far back as 1.0.
On 11/9/11 3:23 AM, matthieu.lochegn...@altissemiconductor.com wrote:
>
> DRC <dcomman...@users.sourceforge.net> wrote on 08/11/2011 19:37:33:
>
>> Odd that valgrind didn't trap it. Perhaps the low-level datasets aren't
>> ever exercising the Tight Copy filter.
>
> Hi,
>
> are you confident with the few lines for the Tight Copy filter, below
> Pierre's fix?
>
> Those were changed this way by commit 4763 :
>
> while (h > 0) {
> - input->readBytes(ptr, rowSize);
> + memcpy(ptr, srcPtr, rowSize * sizeof(PIXEL_T));
> ptr += stride;
> + srcPtr += w * sizeof(PIXEL_T);
> h--;
> }
>
> I guess the new version does not copy the same number of bytes except in
> 8bpp.
>
> Maybe this could be written :
> while (h > 0) {
> memcpy(ptr, srcPtr, w * sizeof(PIXEL_T));
> ptr += stride;
> srcPtr += w * sizeof(PIXEL_T);
> h--;
> }
>
> or :
> while (h > 0) {
> memcpy(ptr, srcPtr, rowSize);
> ptr += stride;
> srcPtr += rowSize;
> h--;
> }
>
>
> --
> Matthieu Lochegnies
> Altis Semiconductor - http://www.altissemiconductor.com/
>
>
> ------------------------------------------------------------------------------
> RSA(R) Conference 2012
> Save $700 by Nov 18
> Register now
> http://p.sf.net/sfu/rsa-sfdev2dev1
>
>
>
> _______________________________________________
> Tigervnc-devel mailing list
> Tigervnc-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/tigervnc-devel
------------------------------------------------------------------------------
RSA(R) Conference 2012
Save $700 by Nov 18
Register now
http://p.sf.net/sfu/rsa-sfdev2dev1
_______________________________________________
Tigervnc-devel mailing list
Tigervnc-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/tigervnc-devel
