Feature Request Tracker item #3486983, was opened at 2012-02-12 05:45 Message generated for change (Comment added) made by ahuillet You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=1126849&aid=3486983&group_id=254363
Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: FLTK viewer Group: None Status: Open Resolution: None Priority: 5 Private: No Submitted By: clohr (clohr) Assigned to: Pierre Ossman (ossman_) Summary: A dialog box to send DesktopSize requests Initial Comment: Hi, I propose a dialog box to vncviewer allowing user to send DesktopSize requests (see attached patch). I hope you find this usefull ;-) Regard. ---------------------------------------------------------------------- Comment By: Arthur Huillet (ahuillet) Date: 2012-02-29 22:55 Message: Actually, it doesn't generate a ton of resize events: it simply generates one when you are done resizing the window. Therefore it's not that bad. (Actually the resize takes place on the next framebufferUpdate event following the window being resized, which looks a bit strange, but I'm expecting ossman to review and help me improve the patch on this point, if at all possible) "Rejected" was a bit of strong word, ossman simply told me that he was not in favor of the dialog box. I do think it can be rather useful when someone wants to e.g. resize to fullscreen, so we agree on this point. The patch exists, it's not going to be too difficult to submit and restart a discussion. Concerning the failed resizes, I've sent a one liner to the ML that fixes the issues I've been experiencing. I submitted the patch to the mailing list, based on clohr's work. ---------------------------------------------------------------------- Comment By: D. R. Commander (dcommander) Date: 2012-02-29 17:01 Message: Arthur, can you explain why this was rejected (I wasn't privy to the IRC conversation)? I actually think it's a pretty good idea to be able to control this from the client manually rather than automatically. As you drag a window, it's going to generate a lot of DesktopResize events in sequence, causing a lot of resizes on the server, and I could see that playing havoc with running applications that didn't have time to respond to a resize event before the next one arrived. To be clear, technically that would be the application's fault, but there are a lot of ill-behaved applications out there. IMHO, the default behavior should be to either automatically scale or scrollbar the window when it is resized (selectable via a GUI option), but there should be another option to do a one-time resize of the remote desktop to where it fits exactly within the current client area of the viewer window. That would be exceptionally useful for those who mainly use VNC full-screen. These are all just ideas and visions based on my knowledge of how my users interact with the system. I haven't really looked at this from a technical point of view yet. ---------------------------------------------------------------------- Comment By: clohr (clohr) Date: 2012-02-29 12:59 Message: Hello, Even if my proposal has not it been selected as-is, I'm glad to see that some people are interested. My initial need was to be able to send DeskTopSize requests during the session, not just when starting the viewer. I think both approaches (dialog box and viewer-window resizing) are complementary and are not opposed. But one may be sufficient. However we must keep in mind that server-size of viewer-size are two different things. One can choose to: - Keep them synchronized: When the server-size changes, viewers resize their window. And when a user resizes a viewer, it sends a DesktopSize request to the server that resize itself. - Do not keep them synchronized: The viewer uses either scrollbars or scaling to display server's pictures in its window. In fact, I have also seen strange reactions when the server receives DeskTopSize requests with non-standard sizes. One criterion is that the width must be a multiple of 8. But there may be other criteria that I was not able to determine. We need an expert for this part. :-) Best regards ---------------------------------------------------------------------- Comment By: Arthur Huillet (ahuillet) Date: 2012-02-29 01:22 Message: Hello, Pierre Ossman didn't answer you on this ticket but we had a talk on IRC. He stated that he disagreed rather strongly with a dialog box like your patch does, and that he favors the approach I implemented where the desktop is resized when the user resizes the viewer window. Now, I've tested the patch you have a little, and in some cases it doesn't work - I suspect that the DesktopSize request is not sent at the right time, and that we should not wait for the next FB update. If you try my patch you'll see what I'm talking about - in many cases the desktop is *not* resized when it should. ---------------------------------------------------------------------- Comment By: clohr (clohr) Date: 2012-02-15 09:44 Message: Many thanks ahuillet I added your patch (see file resize_desktop.patch) Regards ---------------------------------------------------------------------- Comment By: clohr (clohr) Date: 2012-02-15 07:39 Message: Hello, Many thanks for your remarks. Here's a new version of my patch with the misspelling corrected. (see file tigervnc-1.1.90_DesktopSizeDialog_v2.patch.gz) Note: If you want, send me your file by email and I'll add it to this ticket. Regards ---------------------------------------------------------------------- Comment By: Arthur Huillet (ahuillet) Date: 2012-02-15 05:05 Message: Oh, apparently I can't attach a file to a ticket that isn't mine. ---------------------------------------------------------------------- Comment By: Arthur Huillet (ahuillet) Date: 2012-02-15 05:05 Message: Hello, I have improved your patch a little bit by adding the ability to simply resize the viewer's window to change the desktop size. Please see the attached file. ---------------------------------------------------------------------- Comment By: Arthur Huillet (ahuillet) Date: 2012-02-14 02:30 Message: Hello, I am *not* a TigerVNC developer so please take my comments with a grain of salt: they are quite probably not relevant. 1- I confirm that your patch works. 2-spelling: s/traditionnal/traditional/ ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=1126849&aid=3486983&group_id=254363 ------------------------------------------------------------------------------ Virtualization & Cloud Management Using Capacity Planning Cloud computing makes use of virtualization - but cloud computing also focuses on allowing computing to be delivered as a service. http://www.accelacomm.com/jaw/sfnl/114/51521223/ _______________________________________________ Tigervnc-devel mailing list Tigervnc-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/tigervnc-devel
