Bug Tracker item #3514162, was opened at 2012-04-02 07:45
Message generated for change (Settings changed) made by ossman_
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=1126848&aid=3514162&group_id=254363
Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: Windows version
Group: trunk
>Status: Closed
>Resolution: Fixed
Priority: 5
Private: No
Submitted By: Michal Suchanek (hramrach)
Assigned to: Peter Åstrand (astrand)
Summary: C++ compile error
Initial Comment:
Patch required to build trunk with mingw besides the .def file problem:
Index: trunk/win/winvnc/JavaViewer.cxx
>> windows.h needs to be included after winsocks2.h
===================================================================
--- trunk/win/winvnc/JavaViewer.cxx (revision 4879)
+++ trunk/win/winvnc/JavaViewer.cxx (working copy)
@@ -16,13 +16,13 @@
* USA.
*/
-#include <windows.h>
#include <winvnc/JavaViewer.h>
#include <winvnc/resource.h>
#include <rdr/MemInStream.h>
#include <rfb/LogWriter.h>
#include <rfb/VNCServerST.h>
#include <rfb_win32/TCharArray.h>
+#include <windows.h>
#define strcasecmp _stricmp
Index: trunk/vncviewer/vncviewer.cxx
>> Not a member. Perhaps wrong placement of ifdef?
===================================================================
--- trunk/vncviewer/vncviewer.cxx (revision 4879)
+++ trunk/vncviewer/vncviewer.cxx (working copy)
@@ -137,7 +137,7 @@
GetSystemMetrics(SM_CYSMICON),
LR_DEFAULTCOLOR | LR_SHARED);
- Fl_Window::default_icons(lg, sm);
+ //Fl_Window::default_icons(lg, sm);
#elif ! defined(__APPLE__)
const int icon_sizes[] = {48, 32, 24, 16};
----------------------------------------------------------------------
>Comment By: Pierre Ossman (ossman_)
Date: 2012-04-26 02:18
Message:
Should be fixed on trunk now.
----------------------------------------------------------------------
Comment By: Michal Suchanek (hramrach)
Date: 2012-04-25 08:58
Message:
That fixes the issue in second hunk.
The first hunk is still needed:
[ 90%] Building CXX object
win/winvnc/CMakeFiles/winvnc4.dir/JavaViewer.cxx.obj
cd /scratch/tigerbin/win/winvnc && /usr/bin/i686-w64-mingw32-g++
-D__BUILD__=\"20120425\" -D_WIN32_IE=0x0500 -D_WIN32_WINNT=0x0500
-DHAVE_CONFIG_H -static-libgcc -O3 -DNDEBUG
@CMakeFiles/winvnc4.dir/includes_CXX.rsp -o
CMakeFiles/winvnc4.dir/JavaViewer.cxx.obj -c
/scratch/tigervnc/trunk/win/winvnc/JavaViewer.cxx
In file included from /scratch/tigervnc/trunk/common/rfb/Timer.h:24:0,
from /scratch/tigervnc/trunk/common/rfb/VNCServerST.h:36,
from /scratch/tigervnc/trunk/win/winvnc/JavaViewer.h:28,
from
/scratch/tigervnc/trunk/win/winvnc/JavaViewer.cxx:20:
/usr/lib/gcc/i686-w64-mingw32/4.6/../../../../i686-w64-mingw32/include/winsock2.h:15:2:
warning: #warning Please include winsock2.h before windows.h [-Wcpp]
----------------------------------------------------------------------
Comment By: Pierre Ossman (ossman_)
Date: 2012-04-25 07:57
Message:
Oops. Forgot to properly update the bundled FLTK. I just committed the
missing pieces. Could you give it a new try?
----------------------------------------------------------------------
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=1126848&aid=3514162&group_id=254363
------------------------------------------------------------------------------
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and
threat landscape has changed and how IT managers can respond. Discussions
will include endpoint security, mobile security and the latest in malware
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
_______________________________________________
Tigervnc-devel mailing list
Tigervnc-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/tigervnc-devel
