On Thu, Sep 06, 2012 at 12:24:41AM -0400, Brian Hinz wrote:
> Is there any good reason why the "rh692048" patch [1] that RedHat, Debain,
> etc. are applying hasn't been merged into the trunk?  I see Martin's point
> regarding the order of the security types in this thread:
> 
> http://www.mail-archive.com/tigervnc-devel@lists.sourceforge.net/msg00746.html
> 
> But as far as I can tell, the order is still honored with the patch
> applied.  The only quirk that I've seen is that after the patch is applied
> the SecurityTypes argument supplied to the server must have "VeNCrypt"
> preceding the VeNCrypt sub-types, otherwise the client will not be
> presented with the VeNCrypt subtypes (ie: '-SecurityTypes TLSvnc, VncAuth'
> works like '-SecurityTypes VncAuth', but '-SecurityTypes
> VeNCrypt,TLSVnc,VncAuth' works like '-SecurityTypes TLSVnc,VncAuth')
> 
> In either case, it seems a bit silly to me not to adopt the patch given
> that basically every major distro has already done so.  By not doing so,
> we're potentially creating multiple releases of the same "version" that are
> incompatible with each other.  I vote to commit it.
> 
> Thanks,
> -brian
> 
> [1] https://bugzilla.redhat.com/show_bug.cgi?id=692048
>  or
> 
> http://svnweb.mageia.org/packages/cauldron/tigervnc/current/SOURCES/tigervnc11-rh692048.patch?view=markup

If I remember correctly, any gtk-vnc based client (like vinagre) wasn't able to
connect to Xvnc when security types were VeNCrypt,VncAuth,None (i.e. when no TLS
was configured). Due to this I created the patch.

+1 for inclusion in upstream

Regards, Adam

-- 
Adam Tkac, Red Hat, Inc.

------------------------------------------------------------------------------
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and 
threat landscape has changed and how IT managers can respond. Discussions 
will include endpoint security, mobile security and the latest in malware 
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
_______________________________________________
Tigervnc-devel mailing list
Tigervnc-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/tigervnc-devel

Reply via email to