[ 
https://issues.apache.org/jira/browse/TIKA-101?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Niall Pemberton updated TIKA-101:
---------------------------------

    Attachment: tika-pom-v2.patch

Hi Chris,

> One minor nit. In the future, when you are adding new files, please add them 
> to the patch as well

Initially I did but my svn client (TortoiseSVN) warned "You've selected added 
folders. The patch won't contain added files within such added folders. Do you 
want to proceed anyway?" When I chose yes the patch file also appeared to 
contain duplicate copies of src.xml and bin.xml - so I thought it best to just 
attach them directly to the ticket. Perhaps a later TortoiseSVN version fixes 
this.

Also I notice you added those two files (src.xml and bin.xml) directly under 
the trunk - but the pom.xml is configured to look for them in a new 
src/main/assembly directory - so currently running "mvn site assembly:assembly" 
fails. Theres two options here:

1) Create the new "assembly" directory under src/main and move src.xml and 
bin.xml there
2) Change the configuration in the pom.xml to point to their current location

If it was me I would take (and recommend) the first option - AIUI thats the 
"usual" location in m2. However if you prefer the second option - I'm attaching 
a patch to do that (note the second option also requires a tweak to the src.xml 
to include them in the source distro, which the first option doesn't).

Lastly, I notive that when you added those two files (src.xml and bin.xml) the 
svn property "svn:eol-style" was not set - this should be set to "native" to 
avoid lots of "noise" when people using operating systems with different line 
endings commit. The best way to avoid this in the future is to configure the 
"auto-props" section in your svn client - that way you don't have to remember.  
Some info about how to do this is on the Struts Wiki here: 
http://wiki.apache.org/struts/StrutsMaintenanceSvn


> Improve site and build
> ----------------------
>
>                 Key: TIKA-101
>                 URL: https://issues.apache.org/jira/browse/TIKA-101
>             Project: Tika
>          Issue Type: Task
>          Components: documentation
>    Affects Versions: 0.1-incubator
>            Reporter: Niall Pemberton
>            Assignee: Chris A. Mattmann
>            Priority: Minor
>             Fix For: 0.1-incubator
>
>         Attachments: bin.xml, src.xml, tika-pom-v1.patch, tika-pom-v2.patch
>
>
> Tika site doesn't have links to archives on the mailing list page and 
> Javadocs would good to have. I have a patch for the pom - but I got carried 
> away, so theres a bit more.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to