On Nov 28, 2008, at 7:43 PM, Jukka Zitting wrote:
6) RAT: Apache RAT noticed the following files missing license
info...
!????? /home/hossman/tmp/tika-release/rc1/tika-0.2/src/site/
resources/tika.svg
!????? /home/hossman/tmp/tika-release/rc1/tika-0.2/src/site/
resources/tikaNoText.svg
!????? /home/hossman/tmp/tika-release/rc1/tika-0.2/src/test/
resources/test-documents/testHTML.html
!????? /home/hossman/tmp/tika-release/rc1/tika-0.2/src/test/
resources/test-documents/testHTML_utf8.html
!????? /home/hossman/tmp/tika-release/rc1/tika-0.2/src/test/
resources/test-documents/testRTF.rtf
!????? /home/hossman/tmp/tika-release/rc1/tika-0.2/src/test/
resources/test-documents/testTXT.txt
!????? /home/hossman/tmp/tika-release/rc1/tika-0.2/src/test/
resources/test-documents/testXHTML.html
!????? /home/hossman/tmp/tika-release/rc1/tika-0.2/src/test/
resources/test-documents/testXML.xml
...I don't know if i've ever heard an opinion on needing to include
the
ASL header in *.svg files (they are xml, but they are also clearly
generated by inkscape), but I do remember someone pointing out that
test
data files in formats that are capable of containing comments in
them (ie:
xml, html, etc...) should include the ASL header, such as...
http://svn.apache.org/repos/asf/lucene/solr/trunk/example/exampledocs/hd.xml
I think that having the license header in such test files disrupts the
main purpose of the test cases (i.e. you want to check whether the
extracted text contains some specific test phrase, not necessarily the
Apache license header), so at least I prefer to not include the
license header in those test files. See also
http://markmail.org/message/m7jmgl3qncsffygb for related discussion on
[EMAIL PROTECTED]
However, if the PMC so wishes, I don't see any big problem in us
adding the license headers in these test files. Note that in some
future test files this might be troublesome, but for existing tests I
don't see problems with this.
I agree w/ Jukka here, I don't think those kinds of files need to have
headers
-Grant
