Refactor log library usage in tika-parsers
------------------------------------------

                 Key: TIKA-403
                 URL: https://issues.apache.org/jira/browse/TIKA-403
             Project: Tika
          Issue Type: Improvement
    Affects Versions: 0.7
            Reporter: Attila Király
            Priority: Minor


Currently tika has the following direct depencdencies declared in its pom.xml-s:

tika-core:
- none

tika-parent:
- none

tika-parsers:
- commons-logging 1.1.1
- log4j 1.2.14

In tika-parsers pom.xml it is stated that commons-logging is only a transitive 
dependency and it is not used in tika only in poi and it is only there so tika 
pulls the 1.1.1 version of commons-logging instead of the 1.1 version which is 
pulled by poi. For this usecase there is a better option in maven: move this 
depencency declaration from the <depencencies> element to the 
<dependencyManagement> element. Like so:
<dependencyManagement>
        <dependencies>
                <dependency>
                        <groupId>commons-logging</groupId>
                        <artifactId>commons-logging</artifactId>
                        <version>1.1.1</version>
                </dependency>
        </dependencies>
</dependencyManagement>
The result will be the same but tika-parsers will no more say that it directly 
needs commons-logging as dependency.

I did a search for "log" in the java files of tika-core and tike-parsers and it 
seems that only one class uses logging and its 
org.apache.tika.parser.mbox.MboxParser referencing log4j. I think it should be 
trivial to modify this class to not depend on log4j and so the log4j depencency 
could also be removed from the direct dependencies of tika-parsers.


-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira


Reply via email to