It's not really necessary to define extra steps for table checks with 
aggregate functions like sum. The "table contains" step can easily 
handle columns with aggregate functions as long as no "group by" is 
required. From a testing point of view, the use of aggregate function isn't 
something to recommend anyway, because it makes debugging failing test 
difficult and may hide errors.

This replaces the "sum of" step with a "table contains" 
with aggregates. Sums are only used in the regression tests, which have 
questionable result checks anyway.
You can view, comment on, or merge this pull request online at:

  https://github.com/osm2pgsql-dev/osm2pgsql/pull/2431

-- Commit Summary --

  * bdd: replace sum step with tale check with aggregate

-- File Changes --

    M tests/bdd/regression/import.feature (89)
    M tests/bdd/steps/steps_db.py (17)

-- Patch Links --

https://github.com/osm2pgsql-dev/osm2pgsql/pull/2431.patch
https://github.com/osm2pgsql-dev/osm2pgsql/pull/2431.diff

-- 
Reply to this email directly or view it on GitHub:
https://github.com/osm2pgsql-dev/osm2pgsql/pull/2431
You are receiving this because you are subscribed to this thread.

Message ID: <osm2pgsql-dev/osm2pgsql/pull/[email protected]>
_______________________________________________
Tile-serving mailing list
[email protected]
https://lists.openstreetmap.org/listinfo/tile-serving

Reply via email to