@joto commented on this pull request.


>  
 void expire_tiles_t::expire_tile(uint32_t x, uint32_t y)
 {
-    // Only try to insert to tile into the set if the last inserted tile
-    // is different from this tile.

We don't have any benchmarks that prove that it makes sense, so it might have 
been premature. And it complicated the code. It is also unclear whether this 
should now be done for tiles inside a single geometry or for tiles "shared" 
between geometries which means there are different places where this could go. 
I opted to remove it here and maybe bring it back after all the other 
refactoring of the expire code is done if it seems useful then.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/osm2pgsql-dev/osm2pgsql/pull/2449#discussion_r2745400533
You are receiving this because you are subscribed to this thread.

Message ID: <osm2pgsql-dev/osm2pgsql/pull/2449/review/[email protected]>
_______________________________________________
Tile-serving mailing list
[email protected]
https://lists.openstreetmap.org/listinfo/tile-serving

Reply via email to