The code was a bit weird, because the decision whether to do full area expire 
of boundary only is mixed up with the code to do the full area expire. This 
refactoring fixes that, we decide first what to do and then do it.

What is a bit awkward now is the way we do the box calculation in the 
decide_expire_mode() function only if needed and then later if it wasn't 
done already. But if all goes well this will be cleaned up in a future commit 
when we don't do expire by bounding box any more but by the actual area.
You can view, comment on, or merge this pull request online at:

  https://github.com/osm2pgsql-dev/osm2pgsql/pull/2451

-- Commit Summary --

  * Reorganize expire code

-- File Changes --

    M src/expire-tiles.cpp (55)
    M src/geom-box.hpp (5)
    M tests/test-geom-box.cpp (3)

-- Patch Links --

https://github.com/osm2pgsql-dev/osm2pgsql/pull/2451.patch
https://github.com/osm2pgsql-dev/osm2pgsql/pull/2451.diff

-- 
Reply to this email directly or view it on GitHub:
https://github.com/osm2pgsql-dev/osm2pgsql/pull/2451
You are receiving this because you are subscribed to this thread.

Message ID: <osm2pgsql-dev/osm2pgsql/pull/[email protected]>
_______________________________________________
Tile-serving mailing list
[email protected]
https://lists.openstreetmap.org/listinfo/tile-serving

Reply via email to