On Mon, 23 Mar 2009 20:17:11 +0100 Mario Ferraro <[email protected]> wrote:
> Hi all, > > during my deep refactoring of Osmarender Frontend (still WIP), I've > found some CSS classes that are referenced into rules but seem not to > be actually existent in the CSS section of the stylesheet file (rev > 14224). > Well spotted. > I'm not going to delete them, perhaps they're there with a reason > (some WIP? really dunno :)), let me know if they're to be deleted > (actually fixed in two cases) and I'll commit. > I would be inclined to leave them for now. I think after our classes have been refactored (some time away), we'll see if we can find some kind of utlility to detect these unemployed classes. I personally won't object if you flag them with a comment, but others might disapprove of that approach. > Here it is: > > > osm-map-features-z12: > > * 'natural (typo?) (line 44) Certainly invalid - my fat fingers I think :~) Fix now committed (@14251). > * wetland (line 48) Here's one that isn't employed directly but you should leave alone. The style is set in line #1454. I've only used the "bog" class as a selector because I don't expect it to be used in any other context (i.e. outside "wetland"). I'm just being minimalist, really, probably at the expense of readability. Why don't I just use "bog" as the class? I think it's good to have a hook to aggregate all "wetland" features, both for semantic reasons and to adapt to wetland-wide changes. See: * http://lists.openstreetmap.org/pipermail/tilesathome/2009-February/005595.html for what I'm doing …, and * http://trac.openstreetmap.org/ticket/1585 for what bobkare is doing … … with Osma classes > * sport-tennis (line 64) > * track (in line 1541 is actually existent, but not separated by > comma... typo? As I'm dealing with some little errors on the CSS > parser module I don't know if it's valid anyway, but I think it worth > a fix) It's valid and intentional - see list message link above. > * tourism (lines 118, 956) Please leave :~) > * highway-trunk-link-area-casing (line 291) > Yep, lots of these crazy permutations are not in use. They won't be an issue after the rationalisation has occurred (http://trac.openstreetmap.org/ticket/1476). Cheers _______________________________________________ Tilesathome mailing list [email protected] http://lists.openstreetmap.org/listinfo/tilesathome
