On Sun, Oct 18, 2015 at 10:11:55PM +0700, Рысь wrote: > Just started building the new network with automatic updates and > noticed a very weird thing: when master tincd was reloaded (which sends > updates), it stopped sending updates. > > Debugging session revealed that lookup_config(config_tree, NAME) > returned NULL when NAME was any configuration item from our host file > _after_ SIGHUP. Before it, it returned valid value. I see config_tree > is appended with variables from node's own host file only once, in > setup_myself(). After config reload, config_tree is deleted and created > again, but no reading of host file variables occur since then. > > It not only failed with my own newly introduced variables, but with > every host file specific variable, for example, "Compression".
Ah, that's indeed a bug in tinc 1.0.x.
> I then fixed it with attached patch. It reads host file again on
> SIGHUP or internal reload (and maybe in other cases).
Ok, that looks like it might work.
> If it was fixed later, then blame me using older version, but I see
> this also on completely unpatched 1.0.16.
It is fixed in the 1.1 branch, but as far as I can see the bug is still
in 1.0.26.
--
Met vriendelijke groet / with kind regards,
Guus Sliepen <[email protected]>
signature.asc
Description: Digital signature
_______________________________________________ tinc mailing list [email protected] http://www.tinc-vpn.org/cgi-bin/mailman/listinfo/tinc
