yes, this was a bug. it should be TS_TIMER_MODE instead of TS_USER_MODE.
i fixed this bug a long time ago in tinyos-1.x, but it mysteriously
propagated back when we ported ftsp from T1 to T2.
thanks jiangjie, i committed the fix.
brano
Omprakash Gnawali wrote:
> Looks like a bug - I think mode_ in the following snippet is a typo:
>
> if (mode_ == TS_USER_MODE){
>
> It should be mode.
>
> Brano?
>
> - om_p
>
> On Thu, Apr 9, 2009 at 4:22 PM, Jiangjie He <[email protected]> wrote:
>> Thanks for reply. But I see 'mode_' here is the parameter of the
>> setMode function while 'mode' has the previous mode. if user change to
>> TS_USER_MODE mode,which mode_==TS_USER_MODE, then the function start
>> the timer instead of stopping it?
>>
>> 2009/4/10 Omprakash Gnawali <[email protected]>:
>>> On Wed, Apr 8, 2009 at 6:48 AM, Jiangjie He <[email protected]> wrote:
>>>> Hi, all
>>>> Recently I am reading the code of ftsp. I've noticed a problem in
>>>> /tinyos-2.1.0/tos/lib/ftsp/TimeSyncP.nc. At line 402, is it a mistype
>>>> of "TS_USER_MODE", which should be "TS_TIMER_MODE". In description of
>>>> interface TimeSyncMode, it said the timer is stopped when mode is set
>>>> to TS_USER_MODE. so is it a bug or just my misunderstanding?
> _______________________________________________
> Tinyos-devel mailing list
> [email protected]
> https://www.millennium.berkeley.edu/cgi-bin/mailman/listinfo/tinyos-devel
_______________________________________________
Tinyos-help mailing list
[email protected]
https://www.millennium.berkeley.edu/cgi-bin/mailman/listinfo/tinyos-help
