Can someone change the documentation to reflect this?
Currently it says...
interface PacketLink {
/**
* Set the maximum number of times attempt message delivery
* Default is 0
* @param 'message_t* ONE msg'
* @param maxRetries the maximum number of attempts to deliver
* the message
*/
command void setRetries(message_t *msg, uint16_t maxRetries);
which is kind of confusing especially since the default is 0.
eric
On Thu, Mar 18, 2010 at 7:11 AM, Arik Sapojnik <[email protected]> wrote:
> Jens,
>
> This issue was discussed in the development forum.
> The current implementation is actually using retries parameter as tries.
> So if you set retry to 1, you actually try only 1 time.
>
> Arik
>
>
>
> On Thu, Mar 18, 2010 at 15:58, Jens Burmeister <[email protected]> wrote:
>
>> At the moment, we're testing the Packet Link for the CC2420 and I think
>> there's something wrong in the PacketLinkP.nc
>> (
>> http://tinyos.cvs.sourceforge.net/viewvc/tinyos/tinyos-2.x/tos/chips/cc2420/link/PacketLinkC.nc
>> ).
>>
>>
>> The number of the retries, that is set with setRetries is one more than
>> the actual number of retries, that are performed.
>>
>> When you check the function SubSend.sendDone (line 171), you can see,
>> that the totalRetries counter is increased. In line 178 it's compared to
>> the max-number of retries. But the comparison should be "less or equal"
>> instead of "less than".
>>
>> Consider the example, you want to have max. one (1) retry. after the
>> first try, the counter goes from 0 to 1 which is not less than 1. so
>> theres no more retry and the actual number of retries is zero!
>>
>> Please, can someone check and maybe fix that?
>>
>> best regards
>> jens
>> _______________________________________________
>> Tinyos-help mailing list
>> [email protected]
>> https://www.millennium.berkeley.edu/cgi-bin/mailman/listinfo/tinyos-help
>>
>
>
>
> --
> Best Regards,
> Arik Sapojnik
>
> _______________________________________________
> Tinyos-help mailing list
> [email protected]
> https://www.millennium.berkeley.edu/cgi-bin/mailman/listinfo/tinyos-help
>
--
Eric B. Decker
Senior (over 50 :-) Researcher
_______________________________________________
Tinyos-help mailing list
[email protected]
https://www.millennium.berkeley.edu/cgi-bin/mailman/listinfo/tinyos-help
