Patrick McHardy wrote: > Florian Westphal wrote: > > From: Florian Westphal <[EMAIL PROTECTED]> > > > > The tipc netlink config handler uses the nlmsg_pid from the request > > header as destination for its reply. If the application initialized > > nlmsg_pid to 0, the reply is looped back to the kernel, causing > > hangup. Fix: use nlmsg_pid of the skb that triggered the request. > > > > - genlmsg_unicast(rep_buf, req_nlh->nlmsg_pid); > > + genlmsg_unicast(rep_buf, NETLINK_CB(skb).pid); > > > This is the second time we're seeing this bug within a few > weeks, maybe we should rename NETLINK_CB(skb).pid to dst_pid > to avoid similar confusion in the future? We could even > rename nlmsg_pid to nlmsg_src within the kernel, which should > make it completely clear what is being refered to.
I'm assuming that Patrick's first suggestion should have read "rename NETLINK_CB(skb).pid to src_pid", as there is already a "dst_pid" field in the netlink_skb_parms structure type. I agree that such a change would make things clearer to folks who are relative novices when it comes to Netlink. -- Al ------------------------------------------------------------------------- This SF.net email is sponsored by DB2 Express Download DB2 Express C - the FREE version of DB2 express and take control of your XML. No limits. Just data. Click to get it now. http://sourceforge.net/powerbar/db2/ _______________________________________________ tipc-discussion mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/tipc-discussion
