Hi there: I finally got a few minutes to look at the TIPC 1.6 patch that addresses the problem of socket routines not checking the return status of calls to down_interruptible(). Andrew's patch resolves the problem adequately by substituting calls to down(), which always succeeds; however, it does mean that any process that is waiting on a TIPC socket can't be interrupted by a signal, which isn't ideal.
Fortunately, the whole issue should disappear with TIPC 1.7 since the revised socket code eliminates the TIPC-specific semaphore entirely. So the sooner I can start integrating this stuff into the Linux kernel, the better ... Regards, Al -----Original Message----- From: David Miller [mailto:[EMAIL PROTECTED] Sent: Wednesday, December 12, 2007 2:25 PM To: [EMAIL PROTECTED] Cc: [EMAIL PROTECTED]; [EMAIL PROTECTED]; [EMAIL PROTECTED]; [EMAIL PROTECTED]; Stephens, Allan; [email protected]; [EMAIL PROTECTED]; [EMAIL PROTECTED] Subject: Re: [patch 1/1] Convert the semaphore to a mutex in net/tipc/socket.c From: Andrew Morton <[EMAIL PROTECTED]> Date: Tue, 11 Dec 2007 16:44:45 -0800 > So I'd propose this: I've applied this to net-2.6, thanks Andrew. ------------------------------------------------------------------------- This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2005. http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/ _______________________________________________ tipc-discussion mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/tipc-discussion
