I first implemented node remove as "tipc node remove address ADDRESS", then I noticed there is a "tipc node set address ADDRESS". These should of course be each others counterparts. This made me realise that "node remove" is really a "peer remove". So it became "tipc peer remove address 1.1.2", where address is used as peer identifier. An example of how this scale could be "tipc peer set foo 123 address ADDRESS" where we set foo to 123 for a specific peer to 123.
This also made me realize that "tipc node list" should really be "tipc peer list". I guess we should implement "tipc peer list" as a clone of "tipc node list" and deprecate the later? The remaining question and the primary reason for this cover letter is, should I change the kernel define for this as well? From TIPC_NL_NODE_REMOVE to TIPC_NL_PEER_REMOVE? I'm not sure how it would fit in the current curnel space context. Note that this is not yet merged. Richard Alpe (1): tipc: add peer remove functionality include/linux/tipc_netlink.h | 1 + man/man8/tipc-bearer.8 | 1 + man/man8/tipc-link.8 | 1 + man/man8/tipc-media.8 | 1 + man/man8/tipc-nametable.8 | 1 + man/man8/tipc-node.8 | 1 + man/man8/tipc-peer.8 | 52 +++++++++++++++++++++++++ man/man8/tipc.8 | 1 + tipc/Makefile | 2 +- tipc/peer.c | 93 ++++++++++++++++++++++++++++++++++++++++++++ tipc/peer.h | 21 ++++++++++ tipc/tipc.c | 3 ++ 12 files changed, 177 insertions(+), 1 deletion(-) create mode 100644 man/man8/tipc-peer.8 create mode 100644 tipc/peer.c create mode 100644 tipc/peer.h -- 2.1.4 ------------------------------------------------------------------------------ _______________________________________________ tipc-discussion mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/tipc-discussion
