Yes, this works for me too, and I see no problem with it.

Acked-by Jon Maloy <[email protected]>

Thanks
///jon


On 02/24/2016 11:02 AM, Florian Westphal wrote:
> Jon Maloy <[email protected]> wrote:
>> Anybody who has time to look into this?
> So this appears to work for me, do you see any problems with this?
>
> Subject: [-next] net: tipc: fix null deref crash in tipc-compat config path
>
> msg.dst_sk needs to be set up with a valid socket because some
> callbacks later derive the netns from it.
>
> Fixes: 263ea09084d172d ("Revert "genl: Add genlmsg_new_unicast() for unicast 
> message allocation")
> Reported-by: Jon Maloy <[email protected]>
> Bisected-by: Jon Maloy <[email protected]>
> Signed-off-by: Florian Westphal <[email protected]>
> ---
> diff --git a/net/tipc/netlink_compat.c b/net/tipc/netlink_compat.c
> index de66d8f..d7d050f 100644
> --- a/net/tipc/netlink_compat.c
> +++ b/net/tipc/netlink_compat.c
> @@ -1105,6 +1105,7 @@ static int tipc_nl_compat_recv(struct sk_buff *skb, 
> struct genl_info *info)
>       msg.req = nlmsg_data(req_nlh) + GENL_HDRLEN + TIPC_GENL_HDRLEN;
>       msg.cmd = req_userhdr->cmd;
>       msg.net = genl_info_net(info);
> +     msg.dst_sk = skb->sk;
>   
>       if ((msg.cmd & 0xC000) && (!netlink_net_capable(skb, CAP_NET_ADMIN))) {
>               msg.rep = tipc_get_err_tlv(TIPC_CFG_NOT_NET_ADMIN);


------------------------------------------------------------------------------
Site24x7 APM Insight: Get Deep Visibility into Application Performance
APM + Mobile APM + RUM: Monitor 3 App instances at just $35/Month
Monitor end-to-end web transactions and take corrective actions now
Troubleshoot faster and improve end-user experience. Signup Now!
http://pubads.g.doubleclick.net/gampad/clk?id=272487151&iu=/4140
_______________________________________________
tipc-discussion mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/tipc-discussion

Reply via email to