// file subscr.c I do see tipc_subscrp_subscribe() added on Feb 2nd but the changes are reverted on March 7th version of file. Any reason why the tipc_subscrp_subscribe() is not on latest version?
// Feb 2nd https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=7c13c6224123a6424bd3bc60ef982759754501e9 // March 7th https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=4de13d7ed6ffdcbb34317acaa9236f121176f5f8 It seems the March 7th fix may not needed for Feb 2nd version since some fixes check the null. Please confirm. static void tipc_subscrp_subscribe(struct net *net, struct tipc_subscr *s, struct tipc_subscriber *subscriber, int swap) { struct tipc_net *tn = net_generic(net, tipc_net_id); struct tipc_subscription *sub = NULL; u32 timeout; sub = tipc_subscrp_create(net, s, swap); if (!sub) <<== NILL check here return tipc_conn_terminate(tn->topsrv, subscriber->conid); spin_lock_bh(&subscriber->lock); list_add(&sub->subscrp_list, &subscriber->subscrp_list); tipc_subscrb_get(subscriber); sub->subscriber = subscriber; tipc_nametbl_subscribe(sub); <== At this point, "sub" won't be NULL spin_unlock_bh(&subscriber->lock); ... Thanks, Guna ------------------------------------------------------------------------------ Transform Data into Opportunity. Accelerate data analysis in your applications with Intel Data Analytics Acceleration Library. Click to learn more. http://pubads.g.doubleclick.net/gampad/clk?id=278785471&iu=/4140 _______________________________________________ tipc-discussion mailing list tipc-discussion@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/tipc-discussion
