Acked. This will only be relevant in clusters > 1000 nodes, which I must admit I haven't tested yet.
///jon > -----Original Message----- > From: Dan Carpenter [mailto:[email protected]] > Sent: Friday, 17 June, 2016 05:22 > To: Jon Maloy > Cc: Ying Xue; David S. Miller; [email protected]; tipc- > [email protected]; [email protected] > Subject: [patch -next] tipc: potential shift wrapping bug in map_set() > > "up_map" is a u64 type but we're not using the high 32 bits. > > Fixes: 35c55c9877f8 ('tipc: add neighbor monitoring framework') > Signed-off-by: Dan Carpenter <[email protected]> > > diff --git a/net/tipc/monitor.c b/net/tipc/monitor.c > index 87d4efe..0d489e8 100644 > --- a/net/tipc/monitor.c > +++ b/net/tipc/monitor.c > @@ -122,8 +122,8 @@ static int dom_size(int peers) > > static void map_set(u64 *up_map, int i, unsigned int v) > { > - *up_map &= ~(1 << i); > - *up_map |= (v << i); > + *up_map &= ~(1ULL << i); > + *up_map |= ((u64)v << i); > } > > static int map_get(u64 up_map, int i) ------------------------------------------------------------------------------ What NetFlow Analyzer can do for you? Monitors network bandwidth and traffic patterns at an interface-level. Reveals which users, apps, and protocols are consuming the most bandwidth. Provides multi-vendor support for NetFlow, J-Flow, sFlow and other flows. Make informed decisions using capacity planning reports. http://sdm.link/zohomanageengine _______________________________________________ tipc-discussion mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/tipc-discussion
