On 28/11/16 15:40, Jon Maloy wrote: > > >> -----Original Message----- >> From: Holger Brunck [mailto:holger.bru...@keymile.com] >> Sent: Monday, 28 November, 2016 09:22 >> To: Jon Maloy <jon.ma...@ericsson.com>; tipc-discussion@lists.sourceforge.net >> Subject: Re: [tipc-discussion] TIPC link statistic >> >> Hi Jon, >> >> On 28/11/16 14:53, Jon Maloy wrote: >>>> I saw your patch "tipc: fix link statistics counter errors". I assume it >>>> should >>>>> tackle this issue? I gave it a try with kernel 4.9.0-rc7 on my kmeter1 >>>>> board >>>>> which is a 32 bit powerpc board. Unfortunately the counters are still >>>>> wrong >> in >>>>> the link statistic. Received packets don't appear at all and transmitted >>>>> packages to a remote node are accounted on the broadcast link. >>> I believe you are talking only about the broadcast link here? The figures >>> for >>> broadcast reception are currently missing by design, i.e., they have always >>> been missing. We would need to scan across all broadcast reception links (on >>> the contrary, there is only one broadcast transmission link, which makes >>> that >>> task easy) and accumulate all values, as well as presenting the figures for >>> the individual links. It is not a particularly big or difficult task, but it >>> is certainly more than the small bug corrections I just delivered. I cannot >>> prioritize this myself right now. >> >> no I am not talking about the broadcast link in particular, it was only >> another >> thing I noticed. >> >> I have a TIPC link between two ethernet ports and I send packets >> connectionless >> from a client to a server running on the other side of the link. And what I >> still see is that the RX and TX counter are not increasing in the link >> statistic. After sending 300 packets with a size of 10kB I see: >> >> Link <1.1.9:eth2-1.1.211:eth1> >> ACTIVE MTU:1500 Priority:10 Tolerance:1500 ms Window:50 packets >> RX packets:6 fragments:0/0 bundles:0/0 >> TX packets:4 fragments:0/0 bundles:0/0 >> TX profile sample:2 packets average:60 octets >> 0-64:100% -256:0% -1024:0% -4096:0% -16384:0% -32768:0% -66000:0% >> RX states:17978 probes:368 naks:0 defs:2 dups:2 >> TX states:17772 probes:17386 naks:2 acks:16 dups:0 >> Congestion link:0 Send queue max:0 avg:0 >> >> I just wanted to know that this is a known bug or if there is something >> wrong in >> my setup. >> >> Best regards >> Holger > > The explanation is simple: the patch is not applied on net-next yet, only on > net. It normally takes a few days before David re-applies fixes to net back > to net-next. Since you anyway checked out net-next, you could try to apply > the patch yourself. >
ok maybe my first e-mail was not clear enough. I applied your patch on top of 4.9.0-rc7 and it does not make a difference, thats what I am trying to say. It is still broken on my side. Best regards Holger ------------------------------------------------------------------------------ _______________________________________________ tipc-discussion mailing list tipc-discussion@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/tipc-discussion
