Reviewed-by: me. ///jon
> -----Original Message----- > From: Parthasarathy Bhuvaragan > Sent: Thursday, April 27, 2017 07:54 AM > To: [email protected]; Jon Maloy > <[email protected]>; Ying Xue <[email protected]> > Subject: [PATCH net v1 5/6] tipc: perform skb_linearize() before parsing the > inner header > > In tipc_rcv(), we linearize only the header and usually the packets are > consumed as the nodes permit direct reception. However, if the skb contains > tunnelled message due to fail over or synchronization we parse it in > tipc_node_check_state() without performing linearization. This will cause link > disturbances if the skb was non linear. > > In this commit, we perform linearization for the above messages. > > Signed-off-by: Parthasarathy Bhuvaragan > <[email protected]> > --- > net/tipc/node.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/net/tipc/node.c b/net/tipc/node.c index > e062ef0f01dd..8b08c3952ee7 100644 > --- a/net/tipc/node.c > +++ b/net/tipc/node.c > @@ -1559,6 +1559,8 @@ void tipc_rcv(struct net *net, struct sk_buff *skb, > struct tipc_bearer *b) > > /* Check/update node state before receiving */ > if (unlikely(skb)) { > + if (unlikely(skb_linearize(skb))) > + goto discard; > tipc_node_write_lock(n); > if (tipc_node_check_state(n, skb, bearer_id, &xmitq)) { > if (le->link) { > -- > 2.1.4 ------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot _______________________________________________ tipc-discussion mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/tipc-discussion
