On 05/19/2017 07:35 PM, Parthasarathy Bhuvaragan wrote:
>> diff --git a/net/tipc/subscr.c b/net/tipc/subscr.c
>> index 0bf91cd..94f7357d 100644
>> --- a/net/tipc/subscr.c
>> +++ b/net/tipc/subscr.c
>> @@ -247,7 +247,9 @@ static void tipc_subscrp_delete(struct tipc_subscription
>> *sub)
>> static void tipc_subscrp_cancel(struct tipc_subscr *s,
>> struct tipc_subscriber *subscriber)
>> {
>> + tipc_subscrb_get(s);
> Ying, We have mixed the pointer types, this should be
> tipc_subscrb_get(subscriber) instead.
> So my testing earlier was not correct, i missed this completely.
> Iam off next week, so i can run the test with this fix in 2 weeks.
>
> net/tipc/subscr.c: In function ‘tipc_subscrp_cancel’:
> net/tipc/subscr.c:245:19: warning: passing argument 1 of
> ‘tipc_subscrb_get’ from incompatible pointer type
> tipc_subscrb_get(s);
> ^
> net/tipc/subscr.c:163:13: note: expected ‘struct tipc_subscriber *’ but
> argument is of type ‘struct tipc_subscr *’
> static void tipc_subscrb_get(struct tipc_subscriber *subscriber)
>
Sorry, that's a very bad news! You are right. Please directly help to
correct this directly.
Thanks,
Ying
> /Partha
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
tipc-discussion mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/tipc-discussion
