From: Jon Maloy <[email protected]>
Date: Thu, 12 Oct 2017 16:02:27 +0200
> @@ -259,19 +259,19 @@ static int tipc_rcast_xmit(struct net *net, struct
> sk_buff_head *pkts,
> struct tipc_nlist *dests, u16 *cong_link_cnt)
> {
> struct sk_buff_head _pkts;
> - struct u32_item *n, *tmp;
> - u32 dst, selector;
> + struct tipc_dest *dst, *tmp;
> + u32 dnode, selector;
Order local variables from longest to shortest line please.
> -bool u32_find(struct list_head *l, u32 value)
> +struct tipc_dest *tipc_dest_find(struct list_head *l, u32 node, u32 port)
> {
> - struct u32_item *item;
> + struct tipc_dest *dst;
> + u64 value = (u64)node << 32 | port;
Likewise.
> -bool u32_push(struct list_head *l, u32 value)
> +bool tipc_dest_push(struct list_head *l, u32 node, u32 port)
> {
> - struct u32_item *item;
> + struct tipc_dest *dst;
> + u64 value = (u64)node << 32 | port;
Likewise.
You're probably tired of hearing me say this, so I'll just ask that you
audit the rest of your patch series for this problem as well.
Thank you :-)
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
tipc-discussion mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/tipc-discussion
