From: Jon Maloy <jon.ma...@ericsson.com> Date: Thu, 28 Jun 2018 22:25:04 +0200
> From: Tung Nguyen <tung.q.ngu...@dektech.com.au> > > The function tipc_msg_extract() is using skb_clone() to clone inner > messages from a message bundle buffer. Although this method is safe, > it has an undesired effect that each buffer clone inherits the > true-size of the bundling buffer. As a result, the buffer clone > almost always ends up with being copied anyway by the message > validation function. This makes the cloning into a sub-optimization. > > In this commit we take the consequence of this realization, and copy > each inner message to a separately allocated buffer up front in the > extraction function. > > As a bonus we can now eliminate the two cases where we had to copy > re-routed packets that may potentially go out on the wire again. > > Signed-off-by: Tung Nguyen <tung.q.ngu...@dektech.com.au> > Signed-off-by: Jon Maloy <jon.ma...@ericsson.com> Applied, thanks for following up on this issue. ------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot _______________________________________________ tipc-discussion mailing list tipc-discussion@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/tipc-discussion
