Hi Ying, Thank you very much for having reviewed and tested the patch! Regarding your observation about the "X" in the 'tipc/enable' file, it usually happens when we just enable some of the TIPC trace events (or enable all of them but then disable some...), so please double-check if this is correct.
BR/Tuong -----Original Message----- From: Ying Xue <[email protected]> Sent: Saturday, December 8, 2018 4:14 PM To: Tuong Lien <[email protected]>; [email protected]; [email protected] Subject: Re: [PATCH v1 1/5] tipc: enable tracepoints in tipc Great job! On 11/27/18 8:37 PM, Tuong Lien wrote: > cat trace_pipe > /trace.out & > > To disable all the TIPC trace_events: > > echo 0 > /sys/kernel/debug/tracing/events/tipc/enable > > To clear the trace buffer: > > echo > trace > > d) Like the other trace_events, the feature like 'filter' or 'trigger' > is also usable for the tipc trace_events. > For more details, have a look at: > > Documentation/trace/ftrace.txt > > MAINTAINERS | add two new files 'trace.h' & 'trace.c' in tipc > > Signed-off-by: Tuong Lien <[email protected]> Acked-by: Ying Xue <[email protected]> Tested-by: Ying Xue <[email protected]> The only minor thing is that I found the default value of /sys/kernel/debug/tracing/events/tipc/enable is not 0, but it's "X". Please check why. > --- > net/tipc/Makefile | 4 +- > net/tipc/link.c | 115 +++++++++++++++++++++++++++ > net/tipc/link.h | 1 + > net/tipc/node.c | 61 +++++++++++++++ _______________________________________________ tipc-discussion mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/tipc-discussion
