Hi Ying,
You mean for SOCK_SEQPACKET? But we don't apply smart Nagle to that sock type
(only SOCK_STREAM), nor is there such code in tipc_recvmsg().
BR/Tuong
-----Original Message-----
From: Xue, Ying <ying....@windriver.com>
Sent: Friday, May 8, 2020 9:44 PM
To: Tuong Tong Lien <tuong.t.l...@dektech.com.au>; jma...@redhat.com;
ma...@donjonn.com; tipc-discussion@lists.sourceforge.net
Cc: tipc-dek <tipc-...@dektech.com.au>
Subject: RE: [RFC PATCH 1/2] tipc: fix large latency in smart Nagle streaming
@@ -2011,7 +2021,7 @@ static int tipc_recvstream(struct socket *sock, struct
msghdr *m,
/* Send connection flow control advertisement when applicable */
tsk->rcv_unacked += tsk_inc(tsk, hlen + dlen);
- if (ack || tsk->rcv_unacked >= tsk->rcv_win / TIPC_ACK_RATE)
+ if (tsk->rcv_unacked >= tsk->rcv_win / TIPC_ACK_RATE)
tipc_sk_send_ack(tsk);
Beside tipc_recvstream(), we also need to make the same change in
tipc_recvmsg().
_______________________________________________
tipc-discussion mailing list
tipc-discussion@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/tipc-discussion
