On 5/15/21 11:58 AM, Xin Long wrote:
On Fri, May 14, 2021 at 7:18 PM Jon Maloy <jma...@redhat.com> wrote:
On 5/14/21 6:10 PM, patchwork-bot+netdev...@kernel.org wrote:
Hello:
This patch was applied to netdev/net.git (refs/heads/master):
On Fri, 14 May 2021 08:23:03 +0700 you wrote:
This reverts commit 6bf24dc0cc0cc43b29ba344b66d78590e687e046.
Above fix is not correct and caused memory leak issue.
I just convinced Xin (and myself) that the crash (double free) he was
observing, and which he wanted to fix with the "tipc: fix a race in
tipc_sk_mcast_rcv" patch was due to this bug.
Now, realizing that this is causing a memory leak and not a double free
I suspect there might still be an issue.
Does anybody have a theory?
Hi Jon, I think the double free issue was due to the one I fixed in the patch
I posted:
[PATCH net] tipc: skb_linearize the head skb when reassembling msgs
see the changelog.
That makes sense. So, just backport Hoang's patch and re-run the tests,
and we'll have that one confirmed.
///jon
///jon
Fixes: 6bf24dc0cc0c ("net:tipc: Fix a double free in tipc_sk_mcast_rcv")
Acked-by: Jon Maloy <jma...@redhat.com>
Acked-by: Tung Nguyen <tung.q.ngu...@dektech.com.au>
Signed-off-by: Hoang Le <hoang.h...@dektech.com.au>
[...]
Here is the summary with links:
- [net] Revert "net:tipc: Fix a double free in tipc_sk_mcast_rcv"
https://git.kernel.org/netdev/net/c/75016891357a
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
_______________________________________________
tipc-discussion mailing list
tipc-discussion@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/tipc-discussion
