Re: [tipc-discussion] [PATCH v2] net: tipc: resize nlattr array to correct size

[Tung Quang Nguyen via tipc-discussion]

>Subject: [PATCH v2] net: tipc: resize nlattr array to correct size
>
>According to nla_parse_nested_deprecated(), the tb[] is supposed to the
>destination array with maxtype+1 elements. In current
>tipc_nl_media_get() and __tipc_nl_media_set(), a larger array is used
>which is unnecessary. This patch resize them to a proper size.
>
>Fixes: 1e55417d8fc6 ("tipc: add media set to new netlink api")
>Fixes: 46f15c6794fb ("tipc: add media get/dump to new netlink api")
>Signed-off-by: Lin Ma <li...@zju.edu.cn>
>---
>V1 -> V2: add net in title, also add Fixes tag

Reviewed-by: Tung Nguyen <tung.q.ngu...@dektech.com.au>



>
> net/tipc/bearer.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/net/tipc/bearer.c b/net/tipc/bearer.c
>index 53881406e200..cdcd2731860b 100644
>--- a/net/tipc/bearer.c
>+++ b/net/tipc/bearer.c
>@@ -1258,7 +1258,7 @@ int tipc_nl_media_get(struct sk_buff *skb, struct 
>genl_info *info)
>       struct tipc_nl_msg msg;
>       struct tipc_media *media;
>       struct sk_buff *rep;
>-      struct nlattr *attrs[TIPC_NLA_BEARER_MAX + 1];
>+      struct nlattr *attrs[TIPC_NLA_MEDIA_MAX + 1];
>
>       if (!info->attrs[TIPC_NLA_MEDIA])
>               return -EINVAL;
>@@ -1307,7 +1307,7 @@ int __tipc_nl_media_set(struct sk_buff *skb, struct 
>genl_info *info)
>       int err;
>       char *name;
>       struct tipc_media *m;
>-      struct nlattr *attrs[TIPC_NLA_BEARER_MAX + 1];
>+      struct nlattr *attrs[TIPC_NLA_MEDIA_MAX + 1];
>
>       if (!info->attrs[TIPC_NLA_MEDIA])
>               return -EINVAL;
>--
>2.17.1



_______________________________________________
tipc-discussion mailing list
tipc-discussion@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/tipc-discussion