"Jason R. Mastaler" <[EMAIL PROTECTED]> writes:

> Util.py is getting a bit fat. I'd prefer to either extend MTA.py, or
> add a new module.

Well, I added this to MTA.py (raise NotImplementedError in class MTA,
implement it in class Qmail).  Then I finally went to test all this
and found a can of worms.

MTA.py imports Defaults.  AAAAAAAAAAAARGH!!  So I made the factory
function take the name of the MTA as a parameter and also take the
default delivery instruction as a parameter.  Then I removed the
Defaults import.

It died again, because MTA.py imports Deliver and Deliver.py imports
Defaults.  This time, the only reason we import Defaults is for
Defaults.PID, which is easily available without importing Defaults.

Should I go this route?  Personally, I would prefer to see as little
library code as possible dependent on Defaults.  I'd rather see us
pass parameters in, for situations such as tmda-ofmipd where we aren't
running under a mail user's UID and therefore much of the Defaults
stuff doesn't make sense.


Tim
_________________________________________________
tmda-workers mailing list ([EMAIL PROTECTED])
http://tmda.net/lists/listinfo/tmda-workers

Reply via email to