----- Original Message ----- From: "Tim Legant" <[EMAIL PROTECTED]> To: <[EMAIL PROTECTED]> Sent: Saturday, January 25, 2003 6:19 PM Subject: Re: IP-based domain (tmda-ofmipd)
> "Jesse Guardiani" <[EMAIL PROTECTED]> writes: <snip> > > 2.) What are everyone's thoughts on turning this mainly tmda-ofmipd virtual > > domain code into a module that all TMDA apps can use? > > I've been thinking about this a bit. I've got to make sure I'm not > going to run into chicken and egg problems and I need to make sure the > solution works in tmda-rfilter, too, since that's another trouble area > with regard to virtual home directories and the fact that, right now, > per-user config files seem to be required. With the same sort of fix > as in in tmda-ofmipd, a global /etc/tmdarc should actually work for > all virtual users. I looked over the tmda-ofmipd code this afternoon, and highlighted the areas that have changed with the addition of virtual domain support. (Hey, I'm not real familiar with TMDA yet, I'm a python newbie, and I don't have a laptop. Give me a break. Yellow and Pink highlighters are the next best thing to vimdiff, IMHO.) It looks to me like you've done a pretty decent job of 'modularizing' the VD code already. I mean, only so much CAN be moved into a module/utility library. There are only two things that I think might be candidates for export into Util or another module: 1.) The command line option, '-S'. This could possibly be moved to a global TMDA configuration file. However, I think providing this option would be a good idea regardless, as special situations may be encountered requiring a deviation from the TMDA general config. (Not to mention that implementing a global TMDA config file would be a bit of a pain.) 2.) The setting of $TCPLOCALIP. This could be abstracted into a function or something. Other than that, I can't think of much else that need be removed. So... we could move Util.getvuserhomedir() into a VD module, just for clarity, and add VD code their as needed. But I think it'll be a rather small module. Still, it would be in keeping with OO design. What do you guys think? Is the python newbie a crazy man? (don't answer that) Jesse > > > Tim > _________________________________________________ > tmda-workers mailing list ([EMAIL PROTECTED]) > http://tmda.net/lists/listinfo/tmda-workers > _________________________________________________ tmda-workers mailing list ([EMAIL PROTECTED]) http://tmda.net/lists/listinfo/tmda-workers
