-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Here is version 2.

Features added this version of the patch:
* --tls=on/off/optional now works
* The Received header is augmented to indicate when encryption was used,
roughly like how Postfix does it, except that tlslite doesn't seem to
provide enough information to implement the full details that Postfix adds.

This version has been tested:
* --ssl, --tls=on, --tls=optional modes
* --one-session, and without
* in the same environment as mentioned before
* Using "openssl s_client --starttls smtp" too

I guess I'd like other people to test this a little before checking it in.

As part of these changes, I also cleaned up some general code
architecture in tmda-ofmipd - e.g. by using "process_message" functions
instead of the crazy multiple inheritance etc. that I introduced when
- --one-session was implemented.

Unfortunately, I used an editor that converts TAB to spaces, so there
are more white-space changes in this patch than one might like. I've
attached two versions of the patch, one using "diff -w" to try and make
it a little easier to review. The changes are quite large anyway though.

Also, I had to modify the TLSAsyncDispatcherMixIn class from tlslite, to
enable STARTTLS to be implemented; the class must be permanently a
base-class of the SMTPSession class, but in STARTTLS mode must remain
dormant until that command is issued. I don't think this will be a
maintenance issue; tlslite doesn't seem to be changing that fast as
Jason noticed!
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.2 (MingW32)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFF4n9whk3bo0lNTrURAtZkAJ9eRv1R5d47UK9whSQ4+eDSLooipQCgomFf
FdvWV+qWQbUqSExhI0fQrO8=
=oKlB
-----END PGP SIGNATURE-----

Attachment: tmda-ofmipd-tlslite.v2.patch.gz
Description: GNU Zip compressed data

Attachment: tmda-ofmipd-tlslite.v2.ignore_ws.patch.gz
Description: GNU Zip compressed data

_________________________________________________
tmda-workers mailing list ([email protected])
http://tmda.net/lists/listinfo/tmda-workers

Reply via email to