-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Overall, the patch looks like it's doing the right thing to me, although
I'm not too familiar with most of the code outside tmda-ofmipd.
A few questions that spring to mind are below; just thinking out loud.
Lloyd Zusman wrote:
> +from types import *
What's the benefit of this v.s. "import types"?
> +DefaultVarPat = re.compile('^[A-Z][A-Z0-9_]*$')
Should this include lower-case letters too?
> + try:
> + if v is None:
> + del os.environ[k]
> + else:
> + os.environ[k] = str(v)
> + except:
> + pass
What's the rationale for ignoring exceptions here?
> + Util.pipecmd('%s %s' % (hook, pendpath), self.show())
Are there any issues that require quoting of these strings to avoid
nasty shell escape issues? For some reason, I thought TMDA external
commands were executed with a list of arguments, rather than a
shell-style string that required parsing?
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.7 (GNU/Linux)
Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org
iD8DBQFGExlxhk3bo0lNTrURAnp6AJ0RHHTM76VcU7W/HJ2a1JAt1xiOAgCff4od
umWmrsqvc/D4OPCyvZGmVHM=
=FGd6
-----END PGP SIGNATURE-----
_________________________________________________
tmda-workers mailing list ([email protected])
http://tmda.net/lists/listinfo/tmda-workers
