Hi

I like it, but some comments:

- The code style is not right for tmux in quite a number of ways.

- I think you should use b64_pton if possible instead of implementing it
  yourself.

- I think it is good to make the default (s) the top buffer.

- Seven options is far too many to add for this. One might be
  acceptable, maybe just on/off or perhaps three or four values if that
  is useful. I suggest you just pick sensible defaults for the rest.

- Personally I don't see any point in supporting more than s, c, p. But
  I suppose the others don't do any harm.




On Thu, Dec 15, 2016 at 05:00:04PM +0100, Stephane Chauveau wrote:
> Hi,
> 
> I implemented OSC-52 support in Tmux
> 
> https://github.com/schauveau/tmux-osc52
> 
> OSC-52 is an XTerm escape sequence that provides access the OS selection
> buffers (CLIPBOARD, PRIMARY, ...).
> 
> The official Tmux release can already set the OS selection for terminals
> that support OSC-52 (e.g, XTerm, urxvt, ...).
> 
> This branch adds OSC-52 support between Tmux and the client applications
> (the programs running in windows and panes).
> 
> When using that branch, the OSC-52 escape sequences emitted by the
> application are interpreted by Tmux to provide access to its internal
> selection buffers.
> 
> The goal is to provide seamless copy-paste between OSC-52 aware applications
> (Vim, Emacs, ...)  and Tmux panes.
> 
> Those new features will work even for people using a terminal application
> that is not OSC-52 aware.
> 
> The directory osc52-utils/ contains several useful files and scripts,
> including a configuration file for emacs-25.1
> 
> See the file osc52-utils/README.txt for more details.
> 
> THIS IS A WORK IN PROGRESS. IT WORKS BUT EXPECT SOME CHANGES IN THE NEAR
> FUTURES.
> 
> Remark, comments and patches are welcome.
> 
> -- 
> You received this message because you are subscribed to the Google Groups 
> "tmux-users" group.
> To unsubscribe from this group and stop receiving emails from it, send an 
> email to [email protected].
> To post to this group, send an email to [email protected].
> For more options, visit https://groups.google.com/d/optout.

-- 
You received this message because you are subscribed to the Google Groups 
"tmux-users" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send an email to [email protected].
For more options, visit https://groups.google.com/d/optout.

Reply via email to